fix(astrolabe): resolve CI failures for code quality checks

- Fix PHP CS Fixer issues (single quotes, indentation)
- Add typed property declarations to ApiController
- Add Psalm baseline to suppress 517 pre-existing errors
- Fix workflow name references (astroglobe → astrolabe)

The CI workflow was previously watching a non-existent path and never
ran. After fixing the path trigger, these pre-existing code quality
issues were discovered. The Psalm baseline allows CI to pass while
tracking technical debt for incremental resolution.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
2026-01-17 10:56:36 +01:00
parent c018268681
commit c4973290a6
6 changed files with 794 additions and 19 deletions
@@ -1,24 +1,24 @@
# Consolidated CI workflow for Astroglobe Nextcloud app
# Consolidated CI workflow for Astrolabe Nextcloud app
#
# Runs on PRs that modify the astroglobe directory
# Runs on PRs that modify the astrolabe directory
# Based on Nextcloud app skeleton workflows
#
# SPDX-FileCopyrightText: 2025 Nextcloud MCP Server contributors
# SPDX-License-Identifier: MIT
name: Astroglobe CI
name: Astrolabe CI
on:
pull_request:
paths:
- 'third_party/astrolabe/**'
- '.github/workflows/astroglobe-ci.yml'
- '.github/workflows/astrolabe-ci.yml'
permissions:
contents: read
concurrency:
group: astroglobe-ci-${{ github.head_ref || github.run_id }}
group: astrolabe-ci-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
@@ -308,7 +308,7 @@ jobs:
runs-on: ubuntu-latest
needs: [changes, node-build, eslint, stylelint, php-cs, psalm, phpunit]
if: always()
name: astroglobe-ci-summary
name: astrolabe-ci-summary
steps:
- name: Summary status
run: |