brandon/nextcloud-mcp-server
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(astrolabe): resolve CI failures for code quality checks

Browse Source 
- Fix PHP CS Fixer issues (single quotes, indentation)
- Add typed property declarations to ApiController
- Add Psalm baseline to suppress 517 pre-existing errors
- Fix workflow name references (astroglobe → astrolabe)

The CI workflow was previously watching a non-existent path and never
ran. After fixing the path trigger, these pre-existing code quality
issues were discovered. The Psalm baseline allows CI to pass while
tracking technical debt for incremental resolution.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
2026-01-17 10:56:36 +01:00
parent c018268681
commit c4973290a6
6 changed files with 794 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/astroglobe-ci.yml → .github/workflows/astrolabe-ci.yml
+6 -6
View File
@@ -1,24 +1,24 @@
# Consolidated CI workflow for Astroglobe Nextcloud app
# Consolidated CI workflow for Astrolabe Nextcloud app
#
# Runs on PRs that modify the astroglobe directory
# Runs on PRs that modify the astrolabe directory
# Based on Nextcloud app skeleton workflows
#
# SPDX-FileCopyrightText: 2025 Nextcloud MCP Server contributors
# SPDX-License-Identifier: MIT
name: Astroglobe CI
name: Astrolabe CI
on:
pull_request:
paths:
- 'third_party/astrolabe/**'
- '.github/workflows/astroglobe-ci.yml'
- '.github/workflows/astrolabe-ci.yml'
permissions:
contents: read
concurrency:
group: astroglobe-ci-${{ github.head_ref || github.run_id }}
group: astrolabe-ci-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
jobs:
@@ -308,7 +308,7 @@ jobs:
runs-on: ubuntu-latest
needs: [changes, node-build, eslint, stylelint, php-cs, psalm, phpunit]
if: always()
name: astroglobe-ci-summary
name: astrolabe-ci-summary
steps:
- name: Summary status
run: |
third_party/astrolabe/lib/Controller/ApiController.php
Vendored
+7 -7
View File
@@ -26,13 +26,13 @@ use Psr\Log\LoggerInterface;
* Handles form submissions and AJAX requests from settings panels.
*/
class ApiController extends Controller {
private $client;
private $userSession;
private $urlGenerator;
private $logger;
private $tokenStorage;
private $config;
private $tokenRefresher;
private McpServerClient $client;
private IUserSession $userSession;
private IURLGenerator $urlGenerator;
private LoggerInterface $logger;
private McpTokenStorage $tokenStorage;
private IConfig $config;
private IdpTokenRefresher $tokenRefresher;
public function __construct(
string $appName,
third_party/astrolabe/lib/Controller/CredentialsController.php
Vendored
+1 -1
View File
@@ -112,7 +112,7 @@ class CredentialsController extends Controller {
// Get MCP server URL from system config (set in config.php)
$mcpServerUrl = $this->config->getSystemValue('mcp_server_url', '');
if (empty($mcpServerUrl)) {
$this->logger->warning("MCP server URL not configured, app password stored locally only");
$this->logger->warning('MCP server URL not configured, app password stored locally only');
return new JSONResponse([
'success' => true,
'partial_success' => true,
third_party/astrolabe/psalm-baseline.xml
Vendored
+774
View File
@@ -0,0 +1,774 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="5.26.1@d747f6500b38ac4f7dfc5edbcae6e4b637d7add0">
<file src="lib/Controller/ApiController.php">
<DeprecatedMethod>
<code><![CDATA[setAppValue]]></code>
<code><![CDATA[setAppValue]]></code>
<code><![CDATA[setAppValue]]></code>
<code><![CDATA[setAppValue]]></code>
</DeprecatedMethod>
<InvalidArrayOffset>
<code><![CDATA[$result['coordinates_3d']]]></code>
<code><![CDATA[$result['pca_variance']]]></code>
<code><![CDATA[$result['query_coords']]]></code>
<code><![CDATA[$webhook['eventFilter']]]></code>
</InvalidArrayOffset>
<MissingClosureReturnType>
<code><![CDATA[function (string $refreshToken) {]]></code>
<code><![CDATA[function (string $refreshToken) {]]></code>
<code><![CDATA[function (string $refreshToken) {]]></code>
<code><![CDATA[function (string $refreshToken) {]]></code>
<code><![CDATA[function (string $refreshToken) {]]></code>
</MissingClosureReturnType>
<MixedArgument>
<code><![CDATA[!empty($eventConfig['filter']) ? $eventConfig['filter'] : null]]></code>
<code><![CDATA[$accessToken]]></code>
<code><![CDATA[$algorithm]]></code>
<code><![CDATA[$eventConfig['event']]]></code>
<code><![CDATA[$fusion]]></code>
</MixedArgument>
<MixedArrayAccess>
<code><![CDATA[$data['algorithm']]]></code>
<code><![CDATA[$data['fusion']]]></code>
<code><![CDATA[$data['limit']]]></code>
<code><![CDATA[$data['scoreThreshold']]]></code>
<code><![CDATA[$eventConfig['event']]]></code>
<code><![CDATA[$eventConfig['event']]]></code>
<code><![CDATA[$eventConfig['filter']]]></code>
<code><![CDATA[$presetEvent['event']]]></code>
<code><![CDATA[$presetEvent['event']]]></code>
<code><![CDATA[$presetEvent['filter']]]></code>
<code><![CDATA[$presetEvent['filter']]]></code>
</MixedArrayAccess>
<MixedAssignment>
<code><![CDATA[$accessToken]]></code>
<code><![CDATA[$algorithm]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$eventConfig]]></code>
<code><![CDATA[$fusion]]></code>
<code><![CDATA[$presetEvent]]></code>
<code><![CDATA[$presetEvent]]></code>
<code><![CDATA[$presetFilter]]></code>
<code><![CDATA[$presetFilter]]></code>
<code><![CDATA[$response['coordinates_3d']]]></code>
<code><![CDATA[$response['pca_variance']]]></code>
<code><![CDATA[$response['query_coords']]]></code>
<code><![CDATA[$webhookFilter]]></code>
</MixedAssignment>
<PossiblyUndefinedArrayOffset>
<code><![CDATA[$webhook['event']]]></code>
<code><![CDATA[$webhook['event']]]></code>
<code><![CDATA[$webhook['event']]]></code>
<code><![CDATA[$webhook['id']]]></code>
</PossiblyUndefinedArrayOffset>
<RiskyTruthyFalsyComparison>
<code><![CDATA[!$accessToken]]></code>
<code><![CDATA[!$accessToken]]></code>
<code><![CDATA[!$accessToken]]></code>
<code><![CDATA[!$accessToken]]></code>
<code><![CDATA[!$accessToken]]></code>
<code><![CDATA[!$newTokenData]]></code>
<code><![CDATA[!$newTokenData]]></code>
<code><![CDATA[!$newTokenData]]></code>
<code><![CDATA[!$newTokenData]]></code>
<code><![CDATA[!$newTokenData]]></code>
<code><![CDATA[!$token]]></code>
<code><![CDATA[empty($webhook['eventFilter'])]]></code>
</RiskyTruthyFalsyComparison>
<TypeDoesNotContainType>
<code><![CDATA[is_array($status)]]></code>
<code><![CDATA[is_array($status)]]></code>
</TypeDoesNotContainType>
<UnusedClass>
<code><![CDATA[ApiController]]></code>
</UnusedClass>
</file>
<file src="lib/Controller/CredentialsController.php">
<MissingPropertyType>
<code><![CDATA[$client]]></code>
<code><![CDATA[$config]]></code>
<code><![CDATA[$httpClientService]]></code>
<code><![CDATA[$logger]]></code>
<code><![CDATA[$tokenStorage]]></code>
<code><![CDATA[$urlGenerator]]></code>
<code><![CDATA[$userSession]]></code>
</MissingPropertyType>
<MixedArgument>
<code><![CDATA[$mcpServerUrl]]></code>
<code><![CDATA[$response->getBody()]]></code>
<code><![CDATA[$userId]]></code>
</MixedArgument>
<MixedArrayAccess>
<code><![CDATA[$body['error']]]></code>
<code><![CDATA[$body['success']]]></code>
</MixedArrayAccess>
<MixedAssignment>
<code><![CDATA[$body]]></code>
<code><![CDATA[$error]]></code>
<code><![CDATA[$hasAccess]]></code>
<code><![CDATA[$hasAccess]]></code>
<code><![CDATA[$httpClient]]></code>
<code><![CDATA[$httpClient]]></code>
<code><![CDATA[$mcpServerUrl]]></code>
<code><![CDATA[$provisionedAt]]></code>
<code><![CDATA[$provisionedAt]]></code>
<code><![CDATA[$response]]></code>
<code><![CDATA[$response]]></code>
<code><![CDATA[$statusCode]]></code>
<code><![CDATA[$statusCode]]></code>
<code><![CDATA[$syncType]]></code>
<code><![CDATA[$syncType]]></code>
<code><![CDATA[$user]]></code>
<code><![CDATA[$user]]></code>
<code><![CDATA[$user]]></code>
<code><![CDATA[$userId]]></code>
<code><![CDATA[$userId]]></code>
<code><![CDATA[$userId]]></code>
</MixedAssignment>
<MixedMethodCall>
<code><![CDATA[debug]]></code>
<code><![CDATA[debug]]></code>
<code><![CDATA[debug]]></code>
<code><![CDATA[deleteBackgroundSyncPassword]]></code>
<code><![CDATA[deleteUserToken]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[get]]></code>
<code><![CDATA[getBackgroundSyncProvisionedAt]]></code>
<code><![CDATA[getBackgroundSyncProvisionedAt]]></code>
<code><![CDATA[getBackgroundSyncType]]></code>
<code><![CDATA[getBackgroundSyncType]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getStatusCode]]></code>
<code><![CDATA[getStatusCode]]></code>
<code><![CDATA[getSystemValue]]></code>
<code><![CDATA[getUID]]></code>
<code><![CDATA[getUID]]></code>
<code><![CDATA[getUID]]></code>
<code><![CDATA[getUser]]></code>
<code><![CDATA[getUser]]></code>
<code><![CDATA[getUser]]></code>
<code><![CDATA[hasBackgroundSyncAccess]]></code>
<code><![CDATA[hasBackgroundSyncAccess]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[newClient]]></code>
<code><![CDATA[newClient]]></code>
<code><![CDATA[post]]></code>
<code><![CDATA[storeBackgroundSyncPassword]]></code>
<code><![CDATA[warning]]></code>
<code><![CDATA[warning]]></code>
<code><![CDATA[warning]]></code>
<code><![CDATA[warning]]></code>
</MixedMethodCall>
<RiskyTruthyFalsyComparison>
<code><![CDATA[$body['success'] ?? false]]></code>
</RiskyTruthyFalsyComparison>
<UnusedClass>
<code><![CDATA[CredentialsController]]></code>
</UnusedClass>
</file>
<file src="lib/Controller/OAuthController.php">
<MissingPropertyType>
<code><![CDATA[$client]]></code>
<code><![CDATA[$config]]></code>
<code><![CDATA[$httpClient]]></code>
<code><![CDATA[$l]]></code>
<code><![CDATA[$logger]]></code>
<code><![CDATA[$session]]></code>
<code><![CDATA[$tokenStorage]]></code>
<code><![CDATA[$urlGenerator]]></code>
<code><![CDATA[$userSession]]></code>
</MissingPropertyType>
<MixedArgument>
<code><![CDATA[$authEndpoint]]></code>
<code><![CDATA[$codeVerifier]]></code>
<code><![CDATA[$externalBaseUrl]]></code>
<code><![CDATA[$internalBaseUrl]]></code>
<code><![CDATA[$mcpServerUrl]]></code>
<code><![CDATA[$mcpServerUrl]]></code>
<code><![CDATA[$response->getBody()]]></code>
<code><![CDATA[$response->getBody()]]></code>
<code><![CDATA[$responseBody]]></code>
<code><![CDATA[$statusResponse->getBody()]]></code>
<code><![CDATA[$statusResponse->getBody()]]></code>
<code><![CDATA[$this->urlGenerator->linkToRoute('settings.PersonalSettings.index', [
'section' => 'astrolabe',
'error' => urlencode($e->getMessage())
])]]></code>
<code><![CDATA[$this->urlGenerator->linkToRoute('settings.PersonalSettings.index', ['section' => 'astrolabe'])]]></code>
<code><![CDATA[$this->urlGenerator->linkToRoute('settings.PersonalSettings.index', ['section' => 'astrolabe'])]]></code>
<code><![CDATA[$this->urlGenerator->linkToRoute('settings.PersonalSettings.index', ['section' => 'astrolabe'])]]></code>
</MixedArgument>
<MixedArrayAccess>
<code><![CDATA[$discovery['authorization_endpoint']]]></code>
<code><![CDATA[$discovery['token_endpoint']]]></code>
<code><![CDATA[$discovery['token_endpoint']]]></code>
<code><![CDATA[$statusData['auth_mode']]]></code>
<code><![CDATA[$statusData['oidc']]]></code>
<code><![CDATA[$statusData['oidc']]]></code>
<code><![CDATA[$statusData['oidc']]]></code>
<code><![CDATA[$statusData['oidc']['discovery_url']]]></code>
<code><![CDATA[$statusData['oidc']['discovery_url']]]></code>
<code><![CDATA[$statusData['oidc']['discovery_url']]]></code>
</MixedArrayAccess>
<MixedAssignment>
<code><![CDATA[$authEndpoint]]></code>
<code><![CDATA[$clientSecret]]></code>
<code><![CDATA[$clientSecret]]></code>
<code><![CDATA[$codeVerifier]]></code>
<code><![CDATA[$discovery]]></code>
<code><![CDATA[$discovery]]></code>
<code><![CDATA[$discoveryUrl]]></code>
<code><![CDATA[$discoveryUrl]]></code>
<code><![CDATA[$externalBaseUrl]]></code>
<code><![CDATA[$mcpServerPublicUrl]]></code>
<code><![CDATA[$mcpServerUrl]]></code>
<code><![CDATA[$mcpServerUrl]]></code>
<code><![CDATA[$postData['client_secret']]]></code>
<code><![CDATA[$redirectUri]]></code>
<code><![CDATA[$redirectUri]]></code>
<code><![CDATA[$response]]></code>
<code><![CDATA[$response]]></code>
<code><![CDATA[$response]]></code>
<code><![CDATA[$responseBody]]></code>
<code><![CDATA[$statusData]]></code>
<code><![CDATA[$statusData]]></code>
<code><![CDATA[$statusResponse]]></code>
<code><![CDATA[$statusResponse]]></code>
<code><![CDATA[$storedState]]></code>
<code><![CDATA[$tokenData]]></code>
<code><![CDATA[$tokenEndpoint]]></code>
<code><![CDATA[$user]]></code>
<code><![CDATA[$user]]></code>
<code><![CDATA[$userId]]></code>
<code><![CDATA[$userId]]></code>
</MixedAssignment>
<MixedInferredReturnType>
<code><![CDATA[array]]></code>
</MixedInferredReturnType>
<MixedMethodCall>
<code><![CDATA[deleteUserToken]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[get]]></code>
<code><![CDATA[get]]></code>
<code><![CDATA[get]]></code>
<code><![CDATA[get]]></code>
<code><![CDATA[get]]></code>
<code><![CDATA[get]]></code>
<code><![CDATA[get]]></code>
<code><![CDATA[getAbsoluteURL]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getClientId]]></code>
<code><![CDATA[getClientId]]></code>
<code><![CDATA[getStatusCode]]></code>
<code><![CDATA[getSystemValue]]></code>
<code><![CDATA[getSystemValue]]></code>
<code><![CDATA[getSystemValue]]></code>
<code><![CDATA[getSystemValue]]></code>
<code><![CDATA[getSystemValue]]></code>
<code><![CDATA[getUID]]></code>
<code><![CDATA[getUID]]></code>
<code><![CDATA[getUID]]></code>
<code><![CDATA[getUID]]></code>
<code><![CDATA[getUser]]></code>
<code><![CDATA[getUser]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[linkToRoute]]></code>
<code><![CDATA[linkToRoute]]></code>
<code><![CDATA[linkToRoute]]></code>
<code><![CDATA[linkToRoute]]></code>
<code><![CDATA[linkToRouteAbsolute]]></code>
<code><![CDATA[linkToRouteAbsolute]]></code>
<code><![CDATA[post]]></code>
<code><![CDATA[remove]]></code>
<code><![CDATA[remove]]></code>
<code><![CDATA[remove]]></code>
<code><![CDATA[remove]]></code>
<code><![CDATA[remove]]></code>
<code><![CDATA[remove]]></code>
<code><![CDATA[set]]></code>
<code><![CDATA[set]]></code>
<code><![CDATA[set]]></code>
<code><![CDATA[storeUserToken]]></code>
<code><![CDATA[t]]></code>
<code><![CDATA[t]]></code>
</MixedMethodCall>
<MixedOperand>
<code><![CDATA[$authEndpoint]]></code>
<code><![CDATA[$tokenData['expires_in'] ?? 3600]]></code>
<code><![CDATA[$user->getUID()]]></code>
<code><![CDATA[$user->getUID()]]></code>
</MixedOperand>
<MixedReturnStatement>
<code><![CDATA[$tokenData]]></code>
</MixedReturnStatement>
<RiskyTruthyFalsyComparison>
<code><![CDATA[$error]]></code>
</RiskyTruthyFalsyComparison>
<UnusedClass>
<code><![CDATA[OAuthController]]></code>
</UnusedClass>
</file>
<file src="lib/Listener/AstrolabeAdminSettingsListener.php">
<MixedAssignment>
<code><![CDATA[$value]]></code>
<code><![CDATA[$value]]></code>
</MixedAssignment>
<PossiblyUnusedMethod>
<code><![CDATA[__construct]]></code>
</PossiblyUnusedMethod>
<RedundantCondition>
<code><![CDATA[$event instanceof DeclarativeSettingsSetValueEvent]]></code>
</RedundantCondition>
</file>
<file src="lib/Search/SemanticSearchProvider.php">
<DeprecatedMethod>
<code><![CDATA[getAppValue]]></code>
<code><![CDATA[getAppValue]]></code>
<code><![CDATA[getAppValue]]></code>
<code><![CDATA[getAppValue]]></code>
</DeprecatedMethod>
<MixedArgument>
<code><![CDATA[$chunkNum]]></code>
<code><![CDATA[$docType]]></code>
<code><![CDATA[$mimeType]]></code>
<code><![CDATA[$result['page_count']]]></code>
<code><![CDATA[$result['page_number']]]></code>
<code><![CDATA[$result['total_chunks']]]></code>
<code><![CDATA[$title]]></code>
</MixedArgument>
<MixedAssignment>
<code><![CDATA[$chunkEnd]]></code>
<code><![CDATA[$chunkNum]]></code>
<code><![CDATA[$chunkStart]]></code>
<code><![CDATA[$docType]]></code>
<code><![CDATA[$docType]]></code>
<code><![CDATA[$id]]></code>
<code><![CDATA[$mimeType]]></code>
<code><![CDATA[$params['board_id']]]></code>
<code><![CDATA[$params['page_number']]]></code>
<code><![CDATA[$params['path']]]></code>
<code><![CDATA[$params['title']]]></code>
<code><![CDATA[$score]]></code>
<code><![CDATA[$title]]></code>
</MixedAssignment>
<MixedOperand>
<code><![CDATA[$result['chunk_index']]]></code>
<code><![CDATA[$score]]></code>
</MixedOperand>
<PossiblyUnusedMethod>
<code><![CDATA[__construct]]></code>
</PossiblyUnusedMethod>
<RiskyTruthyFalsyComparison>
<code><![CDATA[$cursor]]></code>
<code><![CDATA[empty($results['error'])]]></code>
<code><![CDATA[empty($status['error'])]]></code>
</RiskyTruthyFalsyComparison>
</file>
<file src="lib/Service/IdpTokenRefresher.php">
<MissingPropertyType>
<code><![CDATA[$config]]></code>
<code><![CDATA[$httpClient]]></code>
<code><![CDATA[$logger]]></code>
<code><![CDATA[$mcpServerClient]]></code>
</MissingPropertyType>
<MixedArgument>
<code><![CDATA[$discoveryResponse->getBody()]]></code>
<code><![CDATA[$internalUrl]]></code>
<code><![CDATA[$response->getBody()]]></code>
<code><![CDATA[$statusResponse->getBody()]]></code>
<code><![CDATA[$tokenData]]></code>
</MixedArgument>
<MixedArrayAccess>
<code><![CDATA[$discovery['token_endpoint']]]></code>
<code><![CDATA[$statusData['oidc']]]></code>
<code><![CDATA[$statusData['oidc']['discovery_url']]]></code>
</MixedArrayAccess>
<MixedAssignment>
<code><![CDATA[$clientSecret]]></code>
<code><![CDATA[$discovery]]></code>
<code><![CDATA[$discoveryResponse]]></code>
<code><![CDATA[$discoveryUrl]]></code>
<code><![CDATA[$internalUrl]]></code>
<code><![CDATA[$mcpServerUrl]]></code>
<code><![CDATA[$response]]></code>
<code><![CDATA[$statusData]]></code>
<code><![CDATA[$statusResponse]]></code>
<code><![CDATA[$tokenData]]></code>
<code><![CDATA[$tokenEndpoint]]></code>
</MixedAssignment>
<MixedInferredReturnType>
<code><![CDATA[array|null]]></code>
</MixedInferredReturnType>
<MixedMethodCall>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[get]]></code>
<code><![CDATA[get]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getClientId]]></code>
<code><![CDATA[getSystemValue]]></code>
<code><![CDATA[getSystemValue]]></code>
<code><![CDATA[getSystemValue]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[info]]></code>
<code><![CDATA[post]]></code>
<code><![CDATA[warning]]></code>
</MixedMethodCall>
<MixedOperand>
<code><![CDATA[$mcpServerUrl]]></code>
</MixedOperand>
<MixedReturnStatement>
<code><![CDATA[$tokenData]]></code>
</MixedReturnStatement>
<PossiblyUnusedMethod>
<code><![CDATA[__construct]]></code>
</PossiblyUnusedMethod>
</file>
<file src="lib/Service/McpServerClient.php">
<MissingPropertyType>
<code><![CDATA[$baseUrl]]></code>
<code><![CDATA[$config]]></code>
<code><![CDATA[$httpClient]]></code>
<code><![CDATA[$logger]]></code>
</MissingPropertyType>
<MixedArgument>
<code><![CDATA[$clientId]]></code>
<code><![CDATA[$response->getBody()]]></code>
<code><![CDATA[$response->getBody()]]></code>
<code><![CDATA[$response->getBody()]]></code>
<code><![CDATA[$response->getBody()]]></code>
<code><![CDATA[$response->getBody()]]></code>
<code><![CDATA[$response->getBody()]]></code>
<code><![CDATA[$response->getBody()]]></code>
<code><![CDATA[$response->getBody()]]></code>
<code><![CDATA[$response->getBody()]]></code>
<code><![CDATA[$response->getBody()]]></code>
<code><![CDATA[$response->getBody()]]></code>
</MixedArgument>
<MixedAssignment>
<code><![CDATA[$clientId]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$response]]></code>
<code><![CDATA[$response]]></code>
<code><![CDATA[$response]]></code>
<code><![CDATA[$response]]></code>
<code><![CDATA[$response]]></code>
<code><![CDATA[$response]]></code>
<code><![CDATA[$response]]></code>
<code><![CDATA[$response]]></code>
<code><![CDATA[$response]]></code>
<code><![CDATA[$response]]></code>
<code><![CDATA[$response]]></code>
</MixedAssignment>
<MixedInferredReturnType>
<code><![CDATA[array]]></code>
<code><![CDATA[array{
* apps?: array<string>,
* error?: string
* }]]></code>
<code><![CDATA[array{
* id?: int,
* event?: string,
* uri?: string,
* event_filter?: array,
* enabled?: bool,
* error?: string
* }]]></code>
<code><![CDATA[array{
* results?: array,
* pca_coordinates?: array,
* algorithm_used?: string,
* total_documents?: int,
* error?: string
* }]]></code>
<code><![CDATA[array{
* results?: array<array{
* id?: string|int,
* title?: string,
* doc_type?: string,
* excerpt?: string,
* score?: float,
* path?: string,
* board_id?: int,
* card_id?: int
* }>,
* total_found?: int,
* algorithm_used?: string,
* error?: string
* }]]></code>
<code><![CDATA[array{
* session_id?: string,
* background_access_granted?: bool,
* background_access_details?: array,
* idp_profile?: array,
* error?: string
* }]]></code>
<code><![CDATA[array{
* status?: string,
* indexed_documents?: int,
* pending_documents?: int,
* last_sync_time?: string,
* documents_per_second?: float,
* errors_24h?: int,
* error?: string
* }]]></code>
<code><![CDATA[array{
* version?: string,
* auth_mode?: string,
* vector_sync_enabled?: bool,
* uptime_seconds?: int,
* management_api_version?: string,
* error?: string
* }]]></code>
<code><![CDATA[array{
* webhooks?: array<array{
* id?: int,
* event?: string,
* uri?: string,
* event_filter?: array,
* enabled?: bool
* }>,
* error?: string
* }]]></code>
<code><![CDATA[array{success?: bool, error?: string}]]></code>
<code><![CDATA[array{success?: bool, message?: string, error?: string}]]></code>
<code><![CDATA[string]]></code>
<code><![CDATA[string]]></code>
</MixedInferredReturnType>
<MixedMethodCall>
<code><![CDATA[debug]]></code>
<code><![CDATA[delete]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[error]]></code>
<code><![CDATA[get]]></code>
<code><![CDATA[get]]></code>
<code><![CDATA[get]]></code>
<code><![CDATA[get]]></code>
<code><![CDATA[get]]></code>
<code><![CDATA[get]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getBody]]></code>
<code><![CDATA[getStatusCode]]></code>
<code><![CDATA[getSystemValue]]></code>
<code><![CDATA[getSystemValue]]></code>
<code><![CDATA[post]]></code>
<code><![CDATA[post]]></code>
<code><![CDATA[post]]></code>
<code><![CDATA[post]]></code>
<code><![CDATA[warning]]></code>
</MixedMethodCall>
<MixedOperand>
<code><![CDATA[$this->baseUrl]]></code>
<code><![CDATA[$this->baseUrl]]></code>
<code><![CDATA[$this->baseUrl]]></code>
<code><![CDATA[$this->baseUrl]]></code>
<code><![CDATA[$this->baseUrl]]></code>
<code><![CDATA[$this->baseUrl]]></code>
<code><![CDATA[$this->baseUrl]]></code>
<code><![CDATA[$this->baseUrl]]></code>
<code><![CDATA[$this->baseUrl]]></code>
<code><![CDATA[$this->baseUrl]]></code>
<code><![CDATA[$this->baseUrl]]></code>
</MixedOperand>
<MixedReturnStatement>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$data]]></code>
<code><![CDATA[$this->baseUrl]]></code>
<code><![CDATA[$this->config->getSystemValue('mcp_server_public_url', $this->baseUrl)]]></code>
</MixedReturnStatement>
<PossiblyUnusedMethod>
<code><![CDATA[__construct]]></code>
<code><![CDATA[getClientId]]></code>
<code><![CDATA[isServerReachable]]></code>
</PossiblyUnusedMethod>
</file>
<file src="lib/Service/McpTokenStorage.php">
<InvalidReturnStatement>
<code><![CDATA[$tokenData]]></code>
</InvalidReturnStatement>
<InvalidReturnType>
<code><![CDATA[array|null]]></code>
</InvalidReturnType>
<MixedArgument>
<code><![CDATA[$newTokenData['access_token']]]></code>
<code><![CDATA[$newTokenData['refresh_token'] ?? $token['refresh_token']]]></code>
<code><![CDATA[time() + ($newTokenData['expires_in'] ?? 3600)]]></code>
</MixedArgument>
<MixedAssignment>
<code><![CDATA[$newTokenData]]></code>
</MixedAssignment>
<MixedInferredReturnType>
<code><![CDATA[string|null]]></code>
</MixedInferredReturnType>
<MixedOperand>
<code><![CDATA[$newTokenData['expires_in'] ?? 3600]]></code>
<code><![CDATA[$token['expires_at']]]></code>
</MixedOperand>
<MixedReturnStatement>
<code><![CDATA[$newTokenData['access_token']]]></code>
<code><![CDATA[$token['access_token']]]></code>
</MixedReturnStatement>
<PossiblyUnusedMethod>
<code><![CDATA[__construct]]></code>
<code><![CDATA[deleteBackgroundSyncPassword]]></code>
<code><![CDATA[storeBackgroundSyncPassword]]></code>
</PossiblyUnusedMethod>
<RiskyTruthyFalsyComparison>
<code><![CDATA[!$token]]></code>
<code><![CDATA[$refreshCallback]]></code>
</RiskyTruthyFalsyComparison>
</file>
<file src="lib/Service/WebhookPresets.php">
<MissingClosureParamType>
<code><![CDATA[$eventConfig]]></code>
</MissingClosureParamType>
<MissingClosureReturnType>
<code><![CDATA[fn ($eventConfig) => $eventConfig['event']]]></code>
</MissingClosureReturnType>
<MixedArgument>
<code><![CDATA[$preset['events']]]></code>
</MixedArgument>
<MixedArrayAccess>
<code><![CDATA[$eventConfig['event']]]></code>
</MixedArrayAccess>
<MixedReturnTypeCoercion>
<code><![CDATA[array<string>]]></code>
<code><![CDATA[array_map(
fn ($eventConfig) => $eventConfig['event'],
$preset['events']
)]]></code>
</MixedReturnTypeCoercion>
<PossiblyUnusedMethod>
<code><![CDATA[getPresetEvents]]></code>
</PossiblyUnusedMethod>
</file>
<file src="lib/Settings/Admin.php">
<DeprecatedMethod>
<code><![CDATA[getAppValue]]></code>
<code><![CDATA[getAppValue]]></code>
<code><![CDATA[getAppValue]]></code>
<code><![CDATA[getAppValue]]></code>
</DeprecatedMethod>
<MixedAssignment>
<code><![CDATA[$clientId]]></code>
<code><![CDATA[$clientSecret]]></code>
<code><![CDATA[$serverUrl]]></code>
</MixedAssignment>
<PossiblyUnusedMethod>
<code><![CDATA[__construct]]></code>
</PossiblyUnusedMethod>
<UnusedProperty>
<code><![CDATA[$client]]></code>
</UnusedProperty>
</file>
<file src="lib/Settings/AdminSection.php">
<UnusedClass>
<code><![CDATA[AdminSection]]></code>
</UnusedClass>
</file>
<file src="lib/Settings/AstrolabeAdminSettings.php">
<PossiblyUnusedMethod>
<code><![CDATA[__construct]]></code>
</PossiblyUnusedMethod>
</file>
<file src="lib/Settings/Personal.php">
<InvalidArrayOffset>
<code><![CDATA[$serverStatus['supports_app_passwords']]]></code>
</InvalidArrayOffset>
<MixedArgument>
<code><![CDATA[$accessToken]]></code>
</MixedArgument>
<MixedAssignment>
<code><![CDATA[$accessToken]]></code>
<code><![CDATA[$supportsAppPasswords]]></code>
</MixedAssignment>
<RiskyTruthyFalsyComparison>
<code><![CDATA[!$token]]></code>
<code><![CDATA[$supportsAppPasswords]]></code>
</RiskyTruthyFalsyComparison>
<UnusedClass>
<code><![CDATA[Personal]]></code>
</UnusedClass>
</file>
<file src="lib/Settings/PersonalSection.php">
<UnusedClass>
<code><![CDATA[PersonalSection]]></code>
</UnusedClass>
</file>
</files>
third_party/astrolabe/psalm.xml
Vendored
+1
View File
@@ -8,6 +8,7 @@
findUnusedBaselineEntry="true"
findUnusedCode="true"
phpVersion="8.1"
errorBaseline="psalm-baseline.xml"
>
<projectFiles>
<directory name="lib" />
third_party/astrolabe/templates/settings/personal.php
Vendored
+5 -5
View File
@@ -47,12 +47,12 @@ style('astrolabe', 'astrolabe-main'); // All CSS bundled into main
// Determine if hybrid mode (multi_user_basic + app passwords)
// In hybrid mode, user needs BOTH OAuth AND app password to be "fully configured"
$isHybridMode = ($_['authMode'] ?? '') === 'multi_user_basic' && !empty($_['supportsAppPasswords']);
$hasOAuthToken = !empty($_['hasOAuthToken']);
$hasBackgroundAccess = !empty($_['hasBackgroundAccess']) || !empty($_['backgroundAccessGranted']);
$hasOAuthToken = !empty($_['hasOAuthToken']);
$hasBackgroundAccess = !empty($_['hasBackgroundAccess']) || !empty($_['backgroundAccessGranted']);
// In hybrid mode: both credentials required; otherwise just background access
$isFullyConfigured = $isHybridMode ? ($hasOAuthToken && $hasBackgroundAccess) : $hasBackgroundAccess;
?>
// In hybrid mode: both credentials required; otherwise just background access
$isFullyConfigured = $isHybridMode ? ($hasOAuthToken && $hasBackgroundAccess) : $hasBackgroundAccess;
?>
<?php if ($isFullyConfigured): ?>
<!-- Already configured -->
<div class="mcp-background-status">