Chris Coutinho
f4759e424d
Added comprehensive webhook management capabilities including: Webhook Client & API: - Added WebhooksClient for Nextcloud webhooks API integration - Create, list, update, and delete webhooks programmatically - Support for event filters in webhook registration Webhook Presets: - Added preset system for common webhook configurations - notes_sync: BeforeNodeDeletedEvent for Notes file operations - calendar_sync: Calendar events (create, update, delete) - deck_sync: Deck card operations - files_sync: File system changes - forms_sync: Form submissions (conditional) - Filter presets by installed apps Admin UI: - Added multi-pane app view with tabs (User Info, Vector Sync, Webhooks) - Webhooks tab for admin users only - Enable/disable preset webhooks via UI - View currently registered webhooks - Uses htmx for dynamic loading and Alpine.js for tab state - Admin permission checking via OCS API CLI Improvements: - Refactored CLI to separate module (cli.py) - Updated entry point in pyproject.toml BeforeNodeDeletedEvent Fix: - Updated ADR-010 to document NodeDeletedEvent issue - BeforeNodeDeletedEvent includes node.id before deletion - NodeDeletedEvent lacks node.id (file already deleted) - Implemented per Nextcloud maintainer recommendation Testing: - Added comprehensive webhook client tests - Added webhook preset filtering tests - Added admin permission tests Configuration: - Updated docker-compose.yml Qdrant settings 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
113 lines
3.8 KiB
Python
113 lines
3.8 KiB
Python
"""Unit tests for webhook preset filtering."""
|
|
|
|
import pytest
|
|
|
|
from nextcloud_mcp_server.server.webhook_presets import (
|
|
filter_presets_by_installed_apps,
|
|
get_preset,
|
|
list_presets,
|
|
)
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_list_all_presets():
|
|
"""Test listing all presets returns 5 presets."""
|
|
presets = list_presets()
|
|
assert len(presets) == 5
|
|
preset_ids = [preset_id for preset_id, _ in presets]
|
|
assert "notes_sync" in preset_ids
|
|
assert "calendar_sync" in preset_ids
|
|
assert "tables_sync" in preset_ids
|
|
assert "forms_sync" in preset_ids
|
|
assert "files_sync" in preset_ids
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_get_preset_existing():
|
|
"""Test getting an existing preset."""
|
|
preset = get_preset("notes_sync")
|
|
assert preset is not None
|
|
assert preset["name"] == "Notes Sync"
|
|
assert preset["app"] == "notes"
|
|
assert len(preset["events"]) == 3
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_get_preset_nonexistent():
|
|
"""Test getting a nonexistent preset returns None."""
|
|
preset = get_preset("nonexistent_sync")
|
|
assert preset is None
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_filter_presets_all_apps_installed():
|
|
"""Test filtering when all apps are installed."""
|
|
installed_apps = ["notes", "calendar", "tables", "forms"]
|
|
filtered = filter_presets_by_installed_apps(installed_apps)
|
|
assert len(filtered) == 5 # All 5 presets (files is always included)
|
|
preset_ids = [preset_id for preset_id, _ in filtered]
|
|
assert "notes_sync" in preset_ids
|
|
assert "calendar_sync" in preset_ids
|
|
assert "tables_sync" in preset_ids
|
|
assert "forms_sync" in preset_ids
|
|
assert "files_sync" in preset_ids
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_filter_presets_subset_installed():
|
|
"""Test filtering when only some apps are installed."""
|
|
installed_apps = ["notes", "calendar"]
|
|
filtered = filter_presets_by_installed_apps(installed_apps)
|
|
assert len(filtered) == 3 # notes, calendar, files
|
|
preset_ids = [preset_id for preset_id, _ in filtered]
|
|
assert "notes_sync" in preset_ids
|
|
assert "calendar_sync" in preset_ids
|
|
assert "files_sync" in preset_ids
|
|
assert "tables_sync" not in preset_ids
|
|
assert "forms_sync" not in preset_ids
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_filter_presets_no_apps_installed():
|
|
"""Test filtering when no optional apps are installed."""
|
|
installed_apps = []
|
|
filtered = filter_presets_by_installed_apps(installed_apps)
|
|
assert len(filtered) == 1 # Only files
|
|
preset_ids = [preset_id for preset_id, _ in filtered]
|
|
assert "files_sync" in preset_ids
|
|
assert "notes_sync" not in preset_ids
|
|
assert "calendar_sync" not in preset_ids
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_filter_presets_files_always_included():
|
|
"""Test that files preset is always included regardless of installed apps."""
|
|
# Empty list
|
|
filtered = filter_presets_by_installed_apps([])
|
|
preset_ids = [preset_id for preset_id, _ in filtered]
|
|
assert "files_sync" in preset_ids
|
|
|
|
# List with other apps but not explicitly "files"
|
|
filtered = filter_presets_by_installed_apps(["notes", "calendar"])
|
|
preset_ids = [preset_id for preset_id, _ in filtered]
|
|
assert "files_sync" in preset_ids
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_filter_presets_forms_included_when_installed():
|
|
"""Test that forms preset is included when Forms app is installed."""
|
|
installed_apps = ["forms"]
|
|
filtered = filter_presets_by_installed_apps(installed_apps)
|
|
preset_ids = [preset_id for preset_id, _ in filtered]
|
|
assert "forms_sync" in preset_ids
|
|
assert len(filtered) == 2 # forms + files
|
|
|
|
|
|
@pytest.mark.unit
|
|
def test_filter_presets_forms_excluded_when_not_installed():
|
|
"""Test that forms preset is excluded when Forms app is not installed."""
|
|
installed_apps = ["notes", "calendar", "tables"]
|
|
filtered = filter_presets_by_installed_apps(installed_apps)
|
|
preset_ids = [preset_id for preset_id, _ in filtered]
|
|
assert "forms_sync" not in preset_ids
|