 Chris Coutinho
|
dfc81923ba
|
fix: resolve CI linting issues for Astroglobe
Fix all ESLint, Stylelint, PHP CS Fixer, and Psalm workflow errors.
Changes:
- ESLint fixes:
- Remove unused APP_NAME constant
- Remove unused TextBoxOutline and TextBoxRemoveOutline components
- Remove unused container variable in adminSettings.js
- Auto-fix trailing commas, line breaks, attribute ordering
- PHP CS Fixer:
- Add trailing commas after last function parameters
- Convert double quotes to single quotes in log messages
- Remove unused NoCSRFRequired import
- Fix arrow function formatting
- Stylelint:
- Update config to use @nextcloud/stylelint-config
- Fix extends directive (was using non-existent package)
- Psalm workflow:
- Fix jq object indexing (.include[0] instead of .[0])
- Correctly extract OCP version from matrix output
All checks now pass locally.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
2025-12-18 00:01:54 +01:00 |
|
|
Chris Coutinho
|
5a6205476a
|
ci: add consolidated GitHub workflow for Astroglobe app
Create single workflow that includes all key checks from Nextcloud app
skeleton instead of copying 14 separate workflow files.
Changes:
- Create astroglobe-ci.yml workflow:
- Triggers on PRs modifying third_party/astroglobe/
- Detects frontend vs PHP changes separately
- Frontend checks: Node.js build, ESLint, Stylelint
- PHP checks: CS Fixer, Psalm static analysis
- Uses official Nextcloud actions (version-matrix, read-package-engines)
- Runs checks only for changed file types
- Summary job for branch protection rules
Benefits:
- Consolidated workflow easier to maintain than 14 files
- Follows Nextcloud app quality standards
- Catches issues before deployment
- Automatic checks on every PR
Based on Nextcloud app skeleton workflows from:
https://github.com/nextcloud/.github
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
2025-12-18 00:01:53 +01:00 |
|