refactor(astrolabe): add PHP property types to fix Psalm errors

Add explicit property type declarations to IdpTokenRefresher,
CredentialsController, OAuthController, and McpServerClient classes.
This improves type safety and allows Psalm to properly infer types,
eliminating MissingPropertyType and many MixedMethodCall errors.

Also adds IClient import where needed and validates getSystemValue
returns to ensure string types before use.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
2026-01-17 21:24:56 +01:00
parent 737f10f190
commit f0ade4ad28
5 changed files with 71 additions and 326 deletions
@@ -23,13 +23,13 @@ use Psr\Log\LoggerInterface;
* Handles storing and validating app passwords for multi-user BasicAuth mode.
*/
class CredentialsController extends Controller {
private $tokenStorage;
private $userSession;
private $logger;
private $config;
private $client;
private $httpClientService;
private $urlGenerator;
private McpTokenStorage $tokenStorage;
private IUserSession $userSession;
private LoggerInterface $logger;
private IConfig $config;
private McpServerClient $client;
private IClientService $httpClientService;
private IURLGenerator $urlGenerator;
public function __construct(
string $appName,