Fix tests

update_webdav_auth.py

@@ -2,73 +2,76 @@
 import sys
 import os
 import base64
-from nextcloud_mcp_server.client import NextcloudClient
+from nextcloud_mcp_server.client import NextcloudClient, HTTPStatusError
 import logging
+import time
 
 logging.basicConfig(level=logging.INFO)
 logger = logging.getLogger(__name__)
 
-def test_webdav_auth():
+def test_webdav_auth_with_attachment():
     """
-    Test function to verify WebDAV authentication and compare with current implementation.
+    Test function to verify WebDAV authentication by attempting to use add_note_attachment.
     """
-    # Create client using standard method
     client = NextcloudClient.from_env()
     print("Client authentication type:", type(client._client.auth).__name__)
     
-    # Get WebDAV base path
     username = os.environ["NEXTCLOUD_USERNAME"]
-    password = os.environ["NEXTCLOUD_PASSWORD"]
     webdav_base = client._get_webdav_base_path()
-    
-    # Test path for Notes directory
     notes_path = f"{webdav_base}/Notes"
-    print(f"Testing WebDAV access to: {notes_path}")
-    
-    # 1. Test with existing client auth
+    print(f"Target WebDAV Notes path for PROPFIND check: {notes_path}")
+
+    temp_note_id = None
     try:
-        print("\nTest 1: Using existing client authentication")
-        response = client._client.request("PROPFIND", notes_path, headers={"Depth": "0"})
-        print(f"Status code: {response.status_code}")
-        if response.status_code >= 400:
-            print(f"Error: {response.text}")
-        else:
-            print("Success! Current auth method works")
-    except Exception as e:
-        print(f"Error: {str(e)}")
-    
-    # 2. Test with explicit Authorization header
-    try:
-        print("\nTest 2: Using explicit Authorization header")
-        # Create base64 encoded credentials
-        auth_string = f"{username}:{password}"
-        auth_bytes = auth_string.encode('ascii')
-        base64_bytes = base64.b64encode(auth_bytes)
-        base64_auth = base64_bytes.decode('ascii')
+        # 1. Create a temporary note to get a note_id
+        print("\nCreating a temporary note...")
+        temp_note_title = f"Temp Note for WebDAV Test - {int(time.time())}"
+        created_note = client.notes_create_note(title=temp_note_title, content="Test content")
+        temp_note_id = created_note.get("id")
+        if not temp_note_id:
+            print("Error: Failed to create temporary note.")
+            return 1
+        print(f"Temporary note created with ID: {temp_note_id}")
+
+        # 2. Attempt to add an attachment (this will trigger the internal PROPFIND)
+        print(f"\nTest: Attempting add_note_attachment for note_id {temp_note_id} (uses client's BasicAuth)")
+        dummy_content = b"This is a test attachment."
+        dummy_filename = "test_attachment.txt"
         
-        # Make request with explicit Authorization header
-        headers = {
-            "Depth": "0",
-            "Authorization": f"Basic {base64_auth}"
-        }
-        
-        # Use client without auth to test explicit header
-        response = client._client.request(
-            "PROPFIND", 
-            notes_path, 
-            headers=headers,
-            auth=None  # Override client auth
+        # The add_note_attachment method itself contains the PROPFIND check
+        # and will log details if it fails.
+        response_data = client.add_note_attachment(
+            note_id=temp_note_id,
+            filename=dummy_filename,
+            content=dummy_content,
+            mime_type="text/plain"
         )
-        
-        print(f"Status code: {response.status_code}")
-        if response.status_code >= 400:
-            print(f"Error: {response.text}")
+        print(f"add_note_attachment response: {response_data}")
+        if response_data and response_data.get("status_code") in [201, 204]:
+             print("Success! add_note_attachment (and its internal PROPFIND) worked.")
         else:
-            print("Success! Explicit authorization header works")
+            print("Failure or unexpected response from add_note_attachment.")
+            # The client.py logs should show details of the PROPFIND if it failed.
+
+    except HTTPStatusError as e:
+        print(f"HTTPStatusError during add_note_attachment: {e.response.status_code} - {e.response.text}")
+        if e.response.status_code == 401:
+            print("Reproduced 401 Unauthorized during add_note_attachment's PROPFIND check!")
+        else:
+            print("An HTTP error other than 401 occurred.")
     except Exception as e:
-        print(f"Error: {str(e)}")
+        print(f"An unexpected error occurred: {str(e)}")
+    finally:
+        # 3. Clean up: Delete the temporary note
+        if temp_note_id:
+            print(f"\nCleaning up: Deleting temporary note ID {temp_note_id}...")
+            try:
+                client.notes_delete_note(note_id=temp_note_id)
+                print(f"Successfully deleted temporary note ID {temp_note_id}.")
+            except Exception as e_del:
+                print(f"Error deleting temporary note ID {temp_note_id}: {str(e_del)}")
     
     return 0
 
 if __name__ == "__main__":
-    sys.exit(test_webdav_auth())
+    sys.exit(test_webdav_auth_with_attachment())