From dd42849d70f9465bd7380d0f5977171740ef14ff Mon Sep 17 00:00:00 2001 From: Chris Coutinho Date: Tue, 23 Dec 2025 09:12:07 -0700 Subject: [PATCH] feat(helm): migrate to new environment variable naming convention MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replace deprecated environment variables with new consolidated names: - VECTOR_SYNC_ENABLED → ENABLE_SEMANTIC_SEARCH - ENABLE_OFFLINE_ACCESS → ENABLE_BACKGROUND_OPERATIONS Update values.yaml structure: - Rename 'vectorSync' section to 'semanticSearch' - Update descriptions to emphasize BM25 hybrid search Benefits: - Aligns with application-level config consolidation - Clearer naming: "semantic search" vs "vector sync" - Maintains backward compatibility via application deprecation handling - Automatic enablement of background ops when semantic search enabled in multi-user modes Updated files: - values.yaml: Renamed vectorSync → semanticSearch - deployment.yaml: New env var names with deprecation comments - NOTES.txt: Updated deployment notes - README.md: Updated documentation and examples 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 --- charts/nextcloud-mcp-server/README.md | 20 +++++++++---------- .../nextcloud-mcp-server/templates/NOTES.txt | 10 +++++----- .../templates/deployment.yaml | 18 ++++++++--------- charts/nextcloud-mcp-server/values.yaml | 11 +++++----- 4 files changed, 30 insertions(+), 29 deletions(-) diff --git a/charts/nextcloud-mcp-server/README.md b/charts/nextcloud-mcp-server/README.md index d1cb5c4..c25e0fd 100644 --- a/charts/nextcloud-mcp-server/README.md +++ b/charts/nextcloud-mcp-server/README.md @@ -208,16 +208,16 @@ The application exposes HTTP health check endpoints: #### Vector Search & Semantic Capabilities (Optional) -Enable semantic search capabilities by deploying a vector database (Qdrant) and embedding service (Ollama or OpenAI). +Enable semantic search capabilities with BM25 hybrid search by deploying a vector database (Qdrant) and embedding service (Ollama or OpenAI). -**Vector Sync Configuration:** +**Semantic Search Configuration:** | Parameter | Description | Default | |-----------|-------------|---------| -| `vectorSync.enabled` | Enable background vector synchronization | `false` | -| `vectorSync.scanInterval` | Scan interval in seconds | `3600` | -| `vectorSync.processorWorkers` | Number of concurrent processor workers | `3` | -| `vectorSync.queueMaxSize` | Maximum queue size for pending documents | `10000` | +| `semanticSearch.enabled` | Enable semantic search and background vector synchronization | `false` | +| `semanticSearch.scanInterval` | Scan interval in seconds | `3600` | +| `semanticSearch.processorWorkers` | Number of concurrent processor workers | `3` | +| `semanticSearch.queueMaxSize` | Maximum queue size for pending documents | `10000` | **Document Chunking Configuration:** @@ -537,8 +537,8 @@ auth: username: admin password: secure-password -# Enable vector sync -vectorSync: +# Enable semantic search +semanticSearch: enabled: true scanInterval: 1800 # Scan every 30 minutes processorWorkers: 5 @@ -576,7 +576,7 @@ ollama: Or use an external Ollama instance: ```yaml -vectorSync: +semanticSearch: enabled: true qdrant: @@ -592,7 +592,7 @@ ollama: Or use OpenAI for embeddings: ```yaml -vectorSync: +semanticSearch: enabled: true qdrant: diff --git a/charts/nextcloud-mcp-server/templates/NOTES.txt b/charts/nextcloud-mcp-server/templates/NOTES.txt index 3533cab..24ce37c 100644 --- a/charts/nextcloud-mcp-server/templates/NOTES.txt +++ b/charts/nextcloud-mcp-server/templates/NOTES.txt @@ -69,12 +69,12 @@ Your Nextcloud MCP Server has been deployed in {{ .Values.auth.mode }} authentic {{- end }} {{- end }} -{{- if .Values.vectorSync.enabled }} +{{- if .Values.semanticSearch.enabled }} -5. Vector Search & Semantic Capabilities: - - Vector Sync: Enabled - - Scan Interval: {{ .Values.vectorSync.scanInterval }}s - - Processor Workers: {{ .Values.vectorSync.processorWorkers }} +5. Semantic Search & Vector Capabilities: + - Semantic Search: Enabled + - Scan Interval: {{ .Values.semanticSearch.scanInterval }}s + - Processor Workers: {{ .Values.semanticSearch.processorWorkers }} {{- if .Values.qdrant.enabled }} - Qdrant: Deployed as subchart ({{ .Release.Name }}-qdrant:6333) {{- else }} diff --git a/charts/nextcloud-mcp-server/templates/deployment.yaml b/charts/nextcloud-mcp-server/templates/deployment.yaml index 27558fb..4808f25 100644 --- a/charts/nextcloud-mcp-server/templates/deployment.yaml +++ b/charts/nextcloud-mcp-server/templates/deployment.yaml @@ -88,8 +88,8 @@ spec: - name: NEXTCLOUD_PUBLIC_ISSUER_URL value: {{ include "nextcloud-mcp-server.publicIssuerUrl" . | quote }} {{- if .Values.auth.multiUserBasic.enableOfflineAccess }} - # Background operations with app passwords - - name: ENABLE_OFFLINE_ACCESS + # Background operations with app passwords (replaces deprecated ENABLE_OFFLINE_ACCESS) + - name: ENABLE_BACKGROUND_OPERATIONS value: "true" - name: TOKEN_STORAGE_DB value: {{ .Values.auth.multiUserBasic.tokenStorageDb | quote }} @@ -182,16 +182,16 @@ spec: value: {{ .Values.documentProcessing.custom.types | quote }} {{- end }} {{- end }} - # Vector Sync - - name: VECTOR_SYNC_ENABLED - value: {{ .Values.vectorSync.enabled | quote }} - {{- if .Values.vectorSync.enabled }} + # Semantic Search (replaces deprecated VECTOR_SYNC_ENABLED) + - name: ENABLE_SEMANTIC_SEARCH + value: {{ .Values.semanticSearch.enabled | quote }} + {{- if .Values.semanticSearch.enabled }} - name: VECTOR_SYNC_SCAN_INTERVAL - value: {{ .Values.vectorSync.scanInterval | quote }} + value: {{ .Values.semanticSearch.scanInterval | quote }} - name: VECTOR_SYNC_PROCESSOR_WORKERS - value: {{ .Values.vectorSync.processorWorkers | quote }} + value: {{ .Values.semanticSearch.processorWorkers | quote }} - name: VECTOR_SYNC_QUEUE_MAX_SIZE - value: {{ .Values.vectorSync.queueMaxSize | quote }} + value: {{ .Values.semanticSearch.queueMaxSize | quote }} {{- end }} # Document Chunking (always set, used by vector sync processor) - name: DOCUMENT_CHUNK_SIZE diff --git a/charts/nextcloud-mcp-server/values.yaml b/charts/nextcloud-mcp-server/values.yaml index 3911c93..0e31be2 100644 --- a/charts/nextcloud-mcp-server/values.yaml +++ b/charts/nextcloud-mcp-server/values.yaml @@ -358,10 +358,11 @@ extraEnvFrom: [] # - secretRef: # name: my-secret -# Vector Sync Configuration -# Background synchronization of Nextcloud content into vector database for semantic search -vectorSync: - # Enable background vector synchronization +# Semantic Search Configuration +# Enable semantic search with BM25 hybrid search and background synchronization +# of Nextcloud content into vector database +semanticSearch: + # Enable semantic search and background vector synchronization enabled: false # Scan interval in seconds (how often to check for changes) scanInterval: 3600 @@ -372,7 +373,7 @@ vectorSync: # Document Chunking Configuration # Controls how documents are split into chunks before embedding -# Only relevant when vectorSync.enabled is true +# Only relevant when semanticSearch.enabled is true documentChunking: # Number of words per chunk (default: 512) # Smaller chunks (256-384): Better for precise searches, more chunks to store