fix(astrolabe): address code review feedback

CRITICAL FIXES:
- Fix tag parsing in workflow to strip "astrolabe-v" instead of "v"
  For tag astrolabe-v0.1.0, now correctly extracts "0.1.0"
- Add workflow filtering to only run on astrolabe-v* tags
  Prevents wasting CI resources on MCP/Helm releases

RECOMMENDED IMPROVEMENTS:
- Make Nextcloud server path configurable in Makefile
  Can now override: make appstore server_dir=/path/to/server
- Add dependency validation to Makefile
  Checks for composer, npm, php before building
- Add signing prerequisite validation
  Verifies server/occ, private key, and certificate exist
- Add dependency checks to all bump scripts
  Validates uv is installed before running cz bump

These changes improve local build experience and prevent common
errors with clear error messages and installation guidance.
This commit is contained in:
Chris Coutinho
2025-12-19 18:34:14 +01:00
parent 4a42b947bc
commit c5f7221fb2
5 changed files with 35 additions and 4 deletions
+3
View File
@@ -2,6 +2,9 @@
# Bump Astrolabe app version
set -e
# Validate dependencies
command -v uv >/dev/null 2>&1 || { echo "Error: uv not found. Install from https://docs.astral.sh/uv/"; exit 1; }
cd third_party/astrolabe
echo "Bumping Astrolabe version..."
+3
View File
@@ -2,6 +2,9 @@
# Bump Helm chart version
set -e
# Validate dependencies
command -v uv >/dev/null 2>&1 || { echo "Error: uv not found. Install from https://docs.astral.sh/uv/"; exit 1; }
cd charts/nextcloud-mcp-server
echo "Bumping Helm chart version..."
+3
View File
@@ -2,6 +2,9 @@
# Bump MCP server version
set -e
# Validate dependencies
command -v uv >/dev/null 2>&1 || { echo "Error: uv not found. Install from https://docs.astral.sh/uv/"; exit 1; }
echo "Bumping MCP server version..."
uv run cz bump --yes