From bc62f2a066b9929563dd123f96dd38237da45a55 Mon Sep 17 00:00:00 2001
From: Chris Coutinho <chris@coutinho.io>
Date: Sun, 25 Jan 2026 21:41:48 +0100
Subject: [PATCH] fix(astrolabe): fix Psalm baseline and ESLint import order

- Update psalm-baseline.xml to match renamed OauthController.php (lowercase 'a')
- Move AlertCircle import to top of PDFViewer.vue to satisfy ESLint import/first rule

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---
 third_party/astrolabe/psalm-baseline.xml           |  4 ++--
 third_party/astrolabe/src/components/PDFViewer.vue | 10 ++++++----
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/third_party/astrolabe/psalm-baseline.xml b/third_party/astrolabe/psalm-baseline.xml
index cf66cc8..2b90c0b 100644
--- a/third_party/astrolabe/psalm-baseline.xml
+++ b/third_party/astrolabe/psalm-baseline.xml
@@ -106,7 +106,7 @@
       <code><![CDATA[CredentialsController]]></code>
     </UnusedClass>
   </file>
-  <file src="lib/Controller/OAuthController.php">
+  <file src="lib/Controller/OauthController.php">
     <MixedArgument>
       <code><![CDATA[$authEndpoint]]></code>
       <code><![CDATA[$codeVerifier]]></code>
@@ -175,7 +175,7 @@
       <code><![CDATA[$error]]></code>
     </RiskyTruthyFalsyComparison>
     <UnusedClass>
-      <code><![CDATA[OAuthController]]></code>
+      <code><![CDATA[OauthController]]></code>
     </UnusedClass>
   </file>
   <file src="lib/Listener/AstrolabeAdminSettingsListener.php">
diff --git a/third_party/astrolabe/src/components/PDFViewer.vue b/third_party/astrolabe/src/components/PDFViewer.vue
index ac81f91..596078f 100644
--- a/third_party/astrolabe/src/components/PDFViewer.vue
+++ b/third_party/astrolabe/src/components/PDFViewer.vue
@@ -15,15 +15,15 @@
 </template>
 
 <script setup>
-import { ref, shallowRef, watch, onMounted, onBeforeUnmount, nextTick } from 'vue'
+import { ref, shallowRef, markRaw, watch, onMounted, onBeforeUnmount, nextTick } from 'vue'
 import { generateUrl } from '@nextcloud/router'
 import { translate as t } from '@nextcloud/l10n'
 import { NcLoadingIcon } from '@nextcloud/vue'
+import AlertCircle from 'vue-material-design-icons/AlertCircle.vue'
 
 // Use global pdfjsLib loaded by pdfjs-loader.mjs (external, not bundled)
 // This avoids Vite transforming ES private fields which breaks fake worker compatibility
 const pdfjsLib = window.pdfjsLib
-import AlertCircle from 'vue-material-design-icons/AlertCircle.vue'
 
 const props = defineProps({
 	filePath: {
@@ -77,7 +77,8 @@ async function loadPDF() {
 			isEvalSupported: false, // Disable eval for CSP
 		})
 
-		pdfDoc.value = await loadingTask.promise
+		// Use markRaw to prevent Vue from wrapping in Proxy (breaks private field access in Chromium)
+		pdfDoc.value = markRaw(await loadingTask.promise)
 		totalPages.value = pdfDoc.value.numPages
 		emit('loaded', { totalPages: totalPages.value })
 
@@ -110,7 +111,8 @@ async function renderPage(pageNum) {
 	}
 
 	try {
-		const page = await pdfDoc.value.getPage(pageNum)
+		// Use markRaw to prevent Vue from wrapping in Proxy (breaks private field access in Chromium)
+		const page = markRaw(await pdfDoc.value.getPage(pageNum))
 		const canvas = canvasRef.value
 
 		if (!canvas) {