From 892340fb66d7628024248941ce94108dfa704554 Mon Sep 17 00:00:00 2001
From: Chris Coutinho <chris@coutinho.io>
Date: Sun, 31 Aug 2025 21:15:43 +0200
Subject: [PATCH] chore: Remove unused model SuccessResponse

---
 nextcloud_mcp_server/models/__init__.py | 2 --
 nextcloud_mcp_server/models/base.py     | 9 +--------
 tests/test_models.py                    | 4 ++--
 3 files changed, 3 insertions(+), 12 deletions(-)

diff --git a/nextcloud_mcp_server/models/__init__.py b/nextcloud_mcp_server/models/__init__.py
index 889a767..6845df9 100644
--- a/nextcloud_mcp_server/models/__init__.py
+++ b/nextcloud_mcp_server/models/__init__.py
@@ -3,7 +3,6 @@
 # Base models
 from .base import (
     BaseResponse,
-    SuccessResponse,
     IdResponse,
     StatusResponse,
 )
@@ -81,7 +80,6 @@ from .webdav import (
 __all__ = [
     # Base models
     "BaseResponse",
-    "SuccessResponse",
     "IdResponse",
     "StatusResponse",
     # Notes models
diff --git a/nextcloud_mcp_server/models/base.py b/nextcloud_mcp_server/models/base.py
index 7550ffb..62bde81 100644
--- a/nextcloud_mcp_server/models/base.py
+++ b/nextcloud_mcp_server/models/base.py
@@ -1,7 +1,7 @@
 """Base Pydantic models for common response patterns."""
 
 from datetime import datetime, timezone
-from typing import Any, Dict, Optional, Union
+from typing import Optional, Union
 
 from pydantic import BaseModel, Field, field_serializer
 
@@ -35,13 +35,6 @@ class BaseResponse(BaseModel):
         return iso_string
 
 
-class SuccessResponse(BaseResponse):
-    """Generic success response."""
-
-    message: Optional[str] = Field(None, description="Optional success message")
-    data: Optional[Dict[str, Any]] = Field(None, description="Optional response data")
-
-
 class IdResponse(BaseResponse):
     """Response model for operations that return a new ID."""
 
diff --git a/tests/test_models.py b/tests/test_models.py
index ef21132..0f7bf0d 100644
--- a/tests/test_models.py
+++ b/tests/test_models.py
@@ -5,7 +5,7 @@ import json
 import logging
 import re
 
-from nextcloud_mcp_server.models.base import BaseResponse, SuccessResponse
+from nextcloud_mcp_server.models.base import BaseResponse
 
 logger = logging.getLogger(__name__)
 
@@ -17,7 +17,7 @@ def test_timestamp_format_validation():
     seen in MCP inspector. MCP expects RFC3339 format with timezone information.
     """
     # Create a response object
-    response = SuccessResponse(message="Test message")
+    response = BaseResponse()
 
     # Serialize to JSON (mimics what MCP inspector sees)
     json_str = response.model_dump_json()