feat(config): consolidate configuration with smart dependency resolution (ADR-021)
Simplifies configuration by consolidating overlapping settings and adding automatic dependency resolution. This makes semantic search configuration significantly easier for users while maintaining 100% backward compatibility. ## Key Changes ### Variable Renaming (Backward Compatible) - `VECTOR_SYNC_ENABLED` → `ENABLE_SEMANTIC_SEARCH` (old name still works) - `ENABLE_OFFLINE_ACCESS` → `ENABLE_BACKGROUND_OPERATIONS` (old name still works) - Deprecation warnings logged when old names used - Old names will be removed in v1.0.0 ### Smart Dependency Resolution - `ENABLE_SEMANTIC_SEARCH` automatically enables background operations in multi-user modes - No need to set both `ENABLE_OFFLINE_ACCESS` and `VECTOR_SYNC_ENABLED` anymore - Single-user mode doesn't auto-enable background ops (not needed) ### Explicit Mode Selection (Optional) - New `MCP_DEPLOYMENT_MODE` environment variable - Valid values: single_user_basic, multi_user_basic, oauth_single_audience, oauth_token_exchange, smithery - Removes ambiguity about which deployment mode is active - Falls back to auto-detection if not set (existing behavior) ### Configuration Templates - Reorganized `env.sample` by deployment mode with clear sections - Added mode-specific quick-start templates: - `env.sample.single-user` - Simplest configuration - `env.sample.oauth-multi-user` - Recommended multi-user - `env.sample.oauth-advanced` - Token exchange mode ## Implementation Details ### Files Modified - `nextcloud_mcp_server/config.py` - Smart dependency resolution helpers - `nextcloud_mcp_server/config_validators.py` - Simplified validation, explicit mode - `tests/unit/test_config_validators.py` - 19 new tests (60 total, all passing) - `env.sample` - Reorganized by deployment mode - `docs/configuration.md` - Complete rewrite with consolidated approach - `docs/troubleshooting.md` - New consolidation troubleshooting section - `README.md` - Updated variable references ### New Files - `docs/ADR-021-configuration-consolidation.md` - Architecture decision record - `docs/configuration-migration-v2.md` - Comprehensive migration guide - `env.sample.single-user` - Single-user quick-start template - `env.sample.oauth-multi-user` - OAuth multi-user quick-start template - `env.sample.oauth-advanced` - Token exchange quick-start template ## User Impact ### Before (Confusing) ```bash ENABLE_OFFLINE_ACCESS=true # Why both? VECTOR_SYNC_ENABLED=true # What's the relationship? ``` ### After (Simplified) ```bash MCP_DEPLOYMENT_MODE=oauth_single_audience # Explicit (optional) ENABLE_SEMANTIC_SEARCH=true # Auto-enables background ops! ``` ### Benefits - 📉 2 fewer variables to understand for semantic search - 📋 Clear intent ("I want semantic search") - 🎯 Explicit mode declaration available - 🔄 100% backward compatible - ✅ All 265 unit tests passing ## Testing - All 60 config validation tests passing - 10 new tests for configuration consolidation - 9 new tests for explicit mode selection - Full unit test suite: 265 tests passing - Backward compatibility verified ## Migration Users can migrate at their own pace. Old variable names continue working with deprecation warnings. See docs/configuration-migration-v2.md for detailed migration instructions. Related: ADR-021 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
Chris Coutinho
@@ -311,20 +311,35 @@ class TestMultiUserBasicValidation:
|
||||
assert mode == AuthMode.MULTI_USER_BASIC
|
||||
assert any("token_encryption_key" in err.lower() for err in errors)
|
||||
|
||||
def test_vector_sync_requires_offline_access(self):
|
||||
"""Test error when vector sync enabled but offline access disabled."""
|
||||
settings = Settings(
|
||||
nextcloud_host="http://localhost",
|
||||
enable_multi_user_basic_auth=True,
|
||||
vector_sync_enabled=True,
|
||||
qdrant_location=":memory:",
|
||||
ollama_base_url="http://ollama:11434",
|
||||
)
|
||||
def test_vector_sync_auto_enables_background_ops_in_multi_user_mode(self):
|
||||
"""Test vector sync automatically enables background operations in multi-user mode (ADR-021)."""
|
||||
# Before ADR-021: This would have failed validation (required explicit ENABLE_OFFLINE_ACCESS)
|
||||
# After ADR-021: vector_sync_enabled auto-enables background operations
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"NEXTCLOUD_HOST": "http://localhost:8080",
|
||||
"ENABLE_MULTI_USER_BASIC_AUTH": "true",
|
||||
"VECTOR_SYNC_ENABLED": "true", # Using old name for backward compat test
|
||||
"QDRANT_LOCATION": ":memory:",
|
||||
"OLLAMA_BASE_URL": "http://ollama:11434",
|
||||
"TOKEN_ENCRYPTION_KEY": "test-key",
|
||||
"TOKEN_STORAGE_DB": "/tmp/test.db",
|
||||
"NEXTCLOUD_OIDC_CLIENT_ID": "test-client-id",
|
||||
"NEXTCLOUD_OIDC_CLIENT_SECRET": "test-client-secret",
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
mode, errors = validate_configuration(settings)
|
||||
settings = get_settings()
|
||||
mode, errors = validate_configuration(settings)
|
||||
|
||||
assert mode == AuthMode.MULTI_USER_BASIC
|
||||
assert any("enable_offline_access" in err.lower() for err in errors)
|
||||
assert mode == AuthMode.MULTI_USER_BASIC
|
||||
# Should have no errors - background operations auto-enabled
|
||||
assert len(errors) == 0
|
||||
# Verify background operations were auto-enabled
|
||||
assert settings.enable_offline_access is True
|
||||
|
||||
|
||||
class TestOAuthSingleAudienceValidation:
|
||||
@@ -396,19 +411,33 @@ class TestOAuthSingleAudienceValidation:
|
||||
assert mode == AuthMode.OAUTH_SINGLE_AUDIENCE
|
||||
assert any("token_encryption_key" in err.lower() for err in errors)
|
||||
|
||||
def test_vector_sync_requires_offline_access(self):
|
||||
"""Test error when vector sync enabled but offline access disabled."""
|
||||
settings = Settings(
|
||||
nextcloud_host="http://localhost",
|
||||
vector_sync_enabled=True,
|
||||
qdrant_location=":memory:",
|
||||
ollama_base_url="http://ollama:11434",
|
||||
)
|
||||
def test_vector_sync_auto_enables_background_ops_in_oauth_mode(self):
|
||||
"""Test vector sync automatically enables background operations in OAuth mode (ADR-021)."""
|
||||
# Before ADR-021: This would have failed validation (required explicit ENABLE_OFFLINE_ACCESS)
|
||||
# After ADR-021: vector_sync_enabled auto-enables background operations in multi-user modes
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"NEXTCLOUD_HOST": "http://localhost:8080",
|
||||
"VECTOR_SYNC_ENABLED": "true",
|
||||
"QDRANT_LOCATION": ":memory:",
|
||||
"OLLAMA_BASE_URL": "http://ollama:11434",
|
||||
"TOKEN_ENCRYPTION_KEY": "test-key",
|
||||
"TOKEN_STORAGE_DB": "/tmp/test.db",
|
||||
# Note: No username/password = OAuth mode
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
mode, errors = validate_configuration(settings)
|
||||
settings = get_settings()
|
||||
mode, errors = validate_configuration(settings)
|
||||
|
||||
assert mode == AuthMode.OAUTH_SINGLE_AUDIENCE
|
||||
assert any("enable_offline_access" in err.lower() for err in errors)
|
||||
assert mode == AuthMode.OAUTH_SINGLE_AUDIENCE
|
||||
# Should have no errors - background operations auto-enabled
|
||||
assert len(errors) == 0
|
||||
# Verify background operations were auto-enabled
|
||||
assert settings.enable_offline_access is True
|
||||
|
||||
|
||||
class TestOAuthTokenExchangeValidation:
|
||||
@@ -576,3 +605,387 @@ class TestEdgeCases:
|
||||
|
||||
# Should have errors for missing host (OAuth mode is default)
|
||||
assert len(errors) > 0
|
||||
|
||||
|
||||
class TestConfigurationConsolidation:
|
||||
"""Test ADR-021 configuration consolidation and backward compatibility.
|
||||
|
||||
Tests verify:
|
||||
- New variable names work (ENABLE_SEMANTIC_SEARCH, ENABLE_BACKGROUND_OPERATIONS)
|
||||
- Old variable names still work (VECTOR_SYNC_ENABLED, ENABLE_OFFLINE_ACCESS)
|
||||
- Deprecation warnings are logged
|
||||
- Auto-enablement of background operations in multi-user modes
|
||||
"""
|
||||
|
||||
def test_new_semantic_search_variable_name(self):
|
||||
"""Test ENABLE_SEMANTIC_SEARCH (new name) works correctly."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"ENABLE_SEMANTIC_SEARCH": "true",
|
||||
"QDRANT_LOCATION": ":memory:",
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
assert settings.vector_sync_enabled is True
|
||||
|
||||
def test_old_vector_sync_variable_name_backward_compat(self):
|
||||
"""Test VECTOR_SYNC_ENABLED (old name) still works for backward compatibility."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"VECTOR_SYNC_ENABLED": "true",
|
||||
"QDRANT_LOCATION": ":memory:",
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
assert settings.vector_sync_enabled is True
|
||||
|
||||
def test_new_background_operations_variable_name(self):
|
||||
"""Test ENABLE_BACKGROUND_OPERATIONS (new name) works correctly."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"ENABLE_BACKGROUND_OPERATIONS": "true",
|
||||
"TOKEN_ENCRYPTION_KEY": "test-key",
|
||||
"TOKEN_STORAGE_DB": "/tmp/test.db",
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
assert settings.enable_offline_access is True
|
||||
|
||||
def test_old_offline_access_variable_name_backward_compat(self):
|
||||
"""Test ENABLE_OFFLINE_ACCESS (old name) still works for backward compatibility."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"ENABLE_OFFLINE_ACCESS": "true",
|
||||
"TOKEN_ENCRYPTION_KEY": "test-key",
|
||||
"TOKEN_STORAGE_DB": "/tmp/test.db",
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
assert settings.enable_offline_access is True
|
||||
|
||||
def test_semantic_search_auto_enables_background_ops_in_oauth_mode(self):
|
||||
"""Test ENABLE_SEMANTIC_SEARCH automatically enables background operations in OAuth mode."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"NEXTCLOUD_HOST": "http://localhost:8080",
|
||||
"ENABLE_SEMANTIC_SEARCH": "true",
|
||||
"QDRANT_LOCATION": ":memory:",
|
||||
"TOKEN_ENCRYPTION_KEY": "test-key",
|
||||
"TOKEN_STORAGE_DB": "/tmp/test.db",
|
||||
# Note: No NEXTCLOUD_USERNAME/PASSWORD = OAuth mode
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
|
||||
# Semantic search enabled
|
||||
assert settings.vector_sync_enabled is True
|
||||
|
||||
# Background operations auto-enabled (even though not explicitly set)
|
||||
assert settings.enable_offline_access is True
|
||||
|
||||
def test_semantic_search_does_not_auto_enable_in_single_user_mode(self):
|
||||
"""Test ENABLE_SEMANTIC_SEARCH does NOT auto-enable background ops in single-user mode."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"NEXTCLOUD_HOST": "http://localhost:8080",
|
||||
"NEXTCLOUD_USERNAME": "admin",
|
||||
"NEXTCLOUD_PASSWORD": "password",
|
||||
"ENABLE_SEMANTIC_SEARCH": "true",
|
||||
"QDRANT_LOCATION": ":memory:",
|
||||
# Note: Username/password set = single-user BasicAuth mode
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
|
||||
# Semantic search enabled
|
||||
assert settings.vector_sync_enabled is True
|
||||
|
||||
# Background operations NOT auto-enabled (not needed in single-user mode)
|
||||
assert settings.enable_offline_access is False
|
||||
|
||||
def test_explicit_background_ops_still_works(self):
|
||||
"""Test explicitly setting ENABLE_BACKGROUND_OPERATIONS works even without semantic search."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"NEXTCLOUD_HOST": "http://localhost:8080",
|
||||
"ENABLE_BACKGROUND_OPERATIONS": "true",
|
||||
"TOKEN_ENCRYPTION_KEY": "test-key",
|
||||
"TOKEN_STORAGE_DB": "/tmp/test.db",
|
||||
# Note: No semantic search enabled
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
|
||||
# Semantic search NOT enabled
|
||||
assert settings.vector_sync_enabled is False
|
||||
|
||||
# Background operations explicitly enabled
|
||||
assert settings.enable_offline_access is True
|
||||
|
||||
def test_both_old_and_new_semantic_search_names_prefers_new(self):
|
||||
"""Test setting both ENABLE_SEMANTIC_SEARCH and VECTOR_SYNC_ENABLED uses new name."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"ENABLE_SEMANTIC_SEARCH": "true",
|
||||
"VECTOR_SYNC_ENABLED": "false", # Old name says false
|
||||
"QDRANT_LOCATION": ":memory:",
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
|
||||
# Should use new name value (true)
|
||||
assert settings.vector_sync_enabled is True
|
||||
|
||||
def test_both_old_and_new_background_ops_names_prefers_new(self):
|
||||
"""Test setting both ENABLE_BACKGROUND_OPERATIONS and ENABLE_OFFLINE_ACCESS uses new name."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"ENABLE_BACKGROUND_OPERATIONS": "true",
|
||||
"ENABLE_OFFLINE_ACCESS": "false", # Old name says false
|
||||
"TOKEN_ENCRYPTION_KEY": "test-key",
|
||||
"TOKEN_STORAGE_DB": "/tmp/test.db",
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
|
||||
# Should use new name value (true)
|
||||
assert settings.enable_offline_access is True
|
||||
|
||||
def test_validation_no_longer_requires_both_variables(self):
|
||||
"""Test validation no longer requires explicit ENABLE_OFFLINE_ACCESS when semantic search enabled."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"NEXTCLOUD_HOST": "http://localhost:8080",
|
||||
"ENABLE_MULTI_USER_BASIC_AUTH": "true",
|
||||
"ENABLE_SEMANTIC_SEARCH": "true",
|
||||
"QDRANT_LOCATION": ":memory:",
|
||||
"TOKEN_ENCRYPTION_KEY": "test-key",
|
||||
"TOKEN_STORAGE_DB": "/tmp/test.db",
|
||||
# OAuth credentials required for app password retrieval (when background ops enabled)
|
||||
"NEXTCLOUD_OIDC_CLIENT_ID": "test-client-id",
|
||||
"NEXTCLOUD_OIDC_CLIENT_SECRET": "test-client-secret",
|
||||
# Note: ENABLE_OFFLINE_ACCESS not set - should auto-enable
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
mode, errors = validate_configuration(settings)
|
||||
|
||||
# Should have no validation errors
|
||||
# (Previously would have required explicit ENABLE_OFFLINE_ACCESS)
|
||||
assert len(errors) == 0
|
||||
assert mode == AuthMode.MULTI_USER_BASIC
|
||||
# Verify background operations were auto-enabled
|
||||
assert settings.enable_offline_access is True
|
||||
|
||||
|
||||
class TestExplicitModeSelection:
|
||||
"""Test ADR-021 explicit mode selection via MCP_DEPLOYMENT_MODE.
|
||||
|
||||
Tests verify:
|
||||
- Explicit mode selection works for all modes
|
||||
- Invalid mode names raise ValueError
|
||||
- Explicit mode takes precedence over auto-detection
|
||||
"""
|
||||
|
||||
def test_explicit_single_user_basic_mode(self):
|
||||
"""Test explicit single_user_basic mode selection."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"NEXTCLOUD_HOST": "http://localhost:8080",
|
||||
"MCP_DEPLOYMENT_MODE": "single_user_basic",
|
||||
"NEXTCLOUD_USERNAME": "admin",
|
||||
"NEXTCLOUD_PASSWORD": "password",
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
mode = detect_auth_mode(settings)
|
||||
|
||||
assert mode == AuthMode.SINGLE_USER_BASIC
|
||||
|
||||
def test_explicit_multi_user_basic_mode(self):
|
||||
"""Test explicit multi_user_basic mode selection."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"NEXTCLOUD_HOST": "http://localhost:8080",
|
||||
"MCP_DEPLOYMENT_MODE": "multi_user_basic",
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
mode = detect_auth_mode(settings)
|
||||
|
||||
assert mode == AuthMode.MULTI_USER_BASIC
|
||||
|
||||
def test_explicit_oauth_single_audience_mode(self):
|
||||
"""Test explicit oauth_single_audience mode selection."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"NEXTCLOUD_HOST": "http://localhost:8080",
|
||||
"MCP_DEPLOYMENT_MODE": "oauth_single_audience",
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
mode = detect_auth_mode(settings)
|
||||
|
||||
assert mode == AuthMode.OAUTH_SINGLE_AUDIENCE
|
||||
|
||||
def test_explicit_oauth_token_exchange_mode(self):
|
||||
"""Test explicit oauth_token_exchange mode selection."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"NEXTCLOUD_HOST": "http://localhost:8080",
|
||||
"MCP_DEPLOYMENT_MODE": "oauth_token_exchange",
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
mode = detect_auth_mode(settings)
|
||||
|
||||
assert mode == AuthMode.OAUTH_TOKEN_EXCHANGE
|
||||
|
||||
def test_explicit_smithery_mode(self):
|
||||
"""Test explicit smithery mode selection."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"MCP_DEPLOYMENT_MODE": "smithery",
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
mode = detect_auth_mode(settings)
|
||||
|
||||
assert mode == AuthMode.SMITHERY_STATELESS
|
||||
|
||||
def test_invalid_deployment_mode_raises_error(self):
|
||||
"""Test invalid MCP_DEPLOYMENT_MODE raises ValueError."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"NEXTCLOUD_HOST": "http://localhost:8080",
|
||||
"MCP_DEPLOYMENT_MODE": "invalid_mode",
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
|
||||
# Should raise ValueError with clear message
|
||||
try:
|
||||
detect_auth_mode(settings)
|
||||
assert False, "Should have raised ValueError"
|
||||
except ValueError as e:
|
||||
assert "Invalid MCP_DEPLOYMENT_MODE" in str(e)
|
||||
assert "invalid_mode" in str(e)
|
||||
assert "Valid values:" in str(e)
|
||||
|
||||
def test_explicit_mode_overrides_auto_detection(self):
|
||||
"""Test explicit mode takes precedence over auto-detection."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"NEXTCLOUD_HOST": "http://localhost:8080",
|
||||
"NEXTCLOUD_USERNAME": "admin", # Would auto-detect as single_user_basic
|
||||
"NEXTCLOUD_PASSWORD": "password",
|
||||
"MCP_DEPLOYMENT_MODE": "oauth_single_audience", # Explicit override
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
mode = detect_auth_mode(settings)
|
||||
|
||||
# Should use explicit mode, not auto-detected mode
|
||||
assert mode == AuthMode.OAUTH_SINGLE_AUDIENCE
|
||||
|
||||
def test_case_insensitive_mode_names(self):
|
||||
"""Test MCP_DEPLOYMENT_MODE is case-insensitive."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"NEXTCLOUD_HOST": "http://localhost:8080",
|
||||
"MCP_DEPLOYMENT_MODE": "OAUTH_SINGLE_AUDIENCE", # Uppercase
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
mode = detect_auth_mode(settings)
|
||||
|
||||
assert mode == AuthMode.OAUTH_SINGLE_AUDIENCE
|
||||
|
||||
def test_whitespace_in_mode_name_stripped(self):
|
||||
"""Test whitespace in MCP_DEPLOYMENT_MODE is stripped."""
|
||||
with patch.dict(
|
||||
os.environ,
|
||||
{
|
||||
"NEXTCLOUD_HOST": "http://localhost:8080",
|
||||
"MCP_DEPLOYMENT_MODE": " oauth_single_audience ", # Whitespace
|
||||
},
|
||||
clear=True,
|
||||
):
|
||||
from nextcloud_mcp_server.config import get_settings
|
||||
|
||||
settings = get_settings()
|
||||
mode = detect_auth_mode(settings)
|
||||
|
||||
assert mode == AuthMode.OAUTH_SINGLE_AUDIENCE
|
||||
|
||||
Reference in New Issue
Block a user